Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GPU AMIP runs with albedo from file #657

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Mar 1, 2024

Purpose

Builds off of #573 - copies the config file introduced there and adds two new runs based on it, using albedo from static map and temporal map instead of function.

The goal of the runs introduced in this PR is to ensure that the coupled simulation can run in the AMIP setup with both types of file reading. Because of this, the simulation length of these runs is only two timesteps. More complex, physically significant setups will be added to the longruns.

closes #583

Content

  • simple AMIP on GPU with bucket albedo from static map (run for 2 timesteps)
  • simple AMIP on GPU with bucket albedo from temporal map (run for 2 timesteps)

  • I have read and checked the items on the review checklist.

@juliasloan25 juliasloan25 force-pushed the js/gpu-amip-albedo branch 3 times, most recently from d65b6f3 to 8b91924 Compare March 2, 2024 00:25
@juliasloan25 juliasloan25 requested a review from LenkaNovak March 2, 2024 01:30
@juliasloan25 juliasloan25 force-pushed the js/gpu-amip-albedo branch 2 times, most recently from c9250dd to a3621c7 Compare March 4, 2024 17:28
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to bring these in, thank you, @juliasloan25 . I just had some questions on why the runs for the different albedo types have different resolutions (unless they're breaking, we should make these consistent, and I would choose the lowest possible resolution, except the target run).

dt_save_to_sol: "1days"
dz_bottom: 30
dz_top: 3000
h_elem: 16
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we mimic the functional albedo resolution config, or do these break for the lower resolution?

Also, I noticed that the temporal albedo slabplanet has a higher resolution than the other two albedo runs. Is it because it was breaking for helem=4?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I'll lower them to 4, I think it should be fine.

The temporal albedo slabplanet has a higher h_elem because I copied these from the non-GPU slabplanet runs, where the functional and static map albedo have h_elem: 4 and temporal has h_elem: 6. I'm not sure why this is, and happy to change them all to 4.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, maybe it is unstable. 🤔 Worth trying though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they all work with the lower resolution :)

@juliasloan25 juliasloan25 enabled auto-merge March 4, 2024 23:05
@juliasloan25 juliasloan25 merged commit 7f73652 into main Mar 5, 2024
6 of 7 checks passed
@juliasloan25 juliasloan25 deleted the js/gpu-amip-albedo branch March 5, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run GPU AMIP sims with bucket albedo from file
2 participants